-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto restore from keys #4
Open
ramontayag
wants to merge
2
commits into
osminogin:master
Choose a base branch
from
ramontayag:auto_restore_from_keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
528ece4
to
bbeeec1
Compare
8ae177b
to
74bd9e8
Compare
20e5378
to
9c836f4
Compare
VERSION defaults to 3.1.1 if not specified.
74bd9e8
to
a65d679
Compare
@osminogin what do you think about this? |
a65d679
to
a54654f
Compare
osminogin
reviewed
Apr 6, 2018
@@ -2,7 +2,7 @@ FROM python:3.6-alpine | |||
|
|||
ARG BUILD_DATE | |||
ARG VCS_REF | |||
ARG VERSION | |||
ARG VERSION=3.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This not needed, because actual version taken from VERSION file in root dir by Makefile.
1ad0eff
to
32e6cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
docker-compose up
anddocker build
work again #8Allows restoration of wallet from the master public or private keys. This allows workflow that is https://12factor.net friendly.